Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pages deploy fails with git rev-parse error on new repo #7687

Merged
merged 3 commits into from
Feb 17, 2025
Merged

fix: pages deploy fails with git rev-parse error on new repo #7687

merged 3 commits into from
Feb 17, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Jan 7, 2025 •
edited
Loading

Fixes #3629

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: unit test should cover it
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: bug fix

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: f60c035

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen marked this pull request as ready for review January 7, 2025 11:33
@emily-shen emily-shen requested review from a team as code owners January 7, 2025 11:33
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 7, 2025 •
edited
Loading

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-wrangler-7687

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7687/npm-package-wrangler-7687

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-wrangler-7687 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-workers-bindings-extension-7687 -O ./cloudflare-workers-bindings-extension.0.0.0-v22d64b604.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v22d64b604.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-create-cloudflare-7687 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-kv-asset-handler-7687

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-miniflare-7687

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-pages-shared-7687

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-unenv-preset-7687

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-vite-plugin-7687

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-vitest-pool-workers-7687

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-workers-editor-shared-7687

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-workers-shared-7687

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13373954945/npm-package-cloudflare-workflows-shared-7687

Note that these links will no longer work once the GitHub Actions artifact expires.

[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20250204.1
workerd 1.20250204.0 1.20250204.0
workerd --version 1.20250204.0 2025-02-04

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen marked this pull request as draft January 7, 2025 11:50
@lrapoport-cf lrapoport-cf added the caretaking Priority for caretaking label Feb 10, 2025
@penalosa penalosa force-pushed the emily/pages-git-bug branch from 30e9209 to 3becfbf Compare February 17, 2025 14:42
@emily-shen emily-shen marked this pull request as ready for review February 17, 2025 15:32
@emily-shen emily-shen merged commit cc853cf into main Feb 17, 2025
27 checks passed
@emily-shen emily-shen deleted the emily/pages-git-bug branch February 17, 2025 16:07
@workers-devprod workers-devprod mentioned this pull request Feb 17, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@penalosa penalosa penalosa approved these changes

Assignees
No one assigned
Labels
caretaking Priority for caretaking
Projects
workers-sdk
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: pages deploy fails with git rev-parse error on new repo
3 participants
@emily-shen @penalosa @lrapoport-cf